Skip to content

Conversation

JAnns98
Copy link
Collaborator

@JAnns98 JAnns98 commented Feb 14, 2025

  1. Edited tutorials
  2. Trimmed excess code in various functions
  3. renamed and split apart some functions to improve clarity
  4. Edited some flag names
  5. fixed some bugs - color palette for melted format or for sankey
  6. added delta-delta legend support
  7. updated mini meta terminology and some delta-delta terminology (including moving delta_g attribute to hedges_g)
  8. Major forest plot edits

Edited proportional flag to improve naming convention consistency. Also removed duplicate code
…removed duplicate code in dabest_object file
…tom_pal should now work with all types of plots
> Changed mini_meta attribute to is_mini_meta to better fit with other attributes (such as is_paired and is_proportional)
> Changed mini_meta_delta class to mini_meta to better fit with other attributes such as delta_delta
…s. Also added an is_delta_delta property

> Trim down repeated code by creating a new function to pick the color for the contrast/swarm/summary bars
> added an is_delta_delta property
> Fix capitalisations and naming terminology (E.g., using Hedges' g now instead of hedges g)
> Major edits to forestplot - removing excess code, removing redundant code, tidying up functions, adding extra error checks, edit some functionality
> fixed some incorrect image tests
> Removed the delta_g dabest attribute and shifted it to hedges_g to better fit the theme of the package
> Fixed functionality where delta2=True and effect_size is not hedges_g or mean_diff but it still generates delta_g data (not supposed to happen)
> updated some code that will be redundant in future python version (~isinstance)
…o one function

> Trimmed excess code
> Created one function to be used for plotting both the swarm bars and contrast bars
>tidied up some code snippets and layout of the plotter code
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@JAnns98 JAnns98 merged commit 62a4dc9 into vnbdev Feb 14, 2025
4 checks passed
@JAnns98 JAnns98 deleted the feat-tutorial-edits branch February 19, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant